Add checkbox for storing viewed files in review - #21
Merged
Conversation
ReeceStevens
commented
May 22, 2026
ReeceStevens
left a comment
ReeceStevens
left a comment
Owner
Author
There was a problem hiding this comment.
I'm placing a temporary review here to test pulling reviews from github
| api::command("sign define PrReviewComment text=C> texthl=Search linehl=DiffText")?; | ||
| api::command("highlight default PrReviewCommentSign guifg=#bf5af2 ctermfg=141")?; | ||
| api::command("sign define PrReviewCommentTop text=╭ texthl=PrReviewCommentSign")?; | ||
| api::command("sign define PrReviewCommentMid text=│ texthl=PrReviewCommentSign")?; |
Owner
Author
There was a problem hiding this comment.
Adding a test comment here
| let end_line = comment.line; | ||
| api::out_write(string!( | ||
| "{:?}: {}-{}\n", | ||
| buffer, |
Owner
Author
There was a problem hiding this comment.
Another test comment here (on the left side)
| side, | ||
| orphaned, | ||
| .. | ||
| }) => { |
Owner
Author
There was a problem hiding this comment.
Longer range comment
import glob
print("Hello!")| r#"syn match reviewStatusFile /^\s\+[MADRC?]\s.\+|/ contains=reviewStatusModifier,reviewStatusPath,reviewStatusPipe"#, | ||
| // File entry: " [x] M src/lib.rs | +45 -12" | ||
| r#"syn match reviewStatusFile /^\s\+\[.\]\s[MADRC?]\s.\+|/ contains=reviewStatusViewed,reviewStatusUnviewed,reviewStatusModifier,reviewStatusPath,reviewStatusPipe"#, | ||
| // Viewed/unviewed checkbox |
Owner
Author
|
Tests are passing locally-- not sure what the source of the compiler error is in CI , but for now I'm moving forward with merge and will resolve that in a subsequent ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.