Skip to content

Enforce WorldScape3D tools ranges - #1418

Open
OldDev78 wants to merge 1 commit into
Redot-Engine:masterfrom
OldDev78:enforce-tool-ranges
Open

OldDev78 wants to merge 1 commit into
Redot-Engine:masterfrom
OldDev78:enforce-tool-ranges

Conversation

@OldDev78

@OldDev78 OldDev78 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Enforce WorldScape3D tools ranges. For some strange reason, the original Godot plugin explicitly allowed users to input values out of bounds. Unfortunately, we inherited this behavior.
Users were previously allowed to input very large values, causing editor disruption and crash.

Fixes #1416 .

Summary by CodeRabbit

  • Bug Fixes
    • Improved spacing between several terrain-editing controls for clearer tool settings.
    • Prevented size, strength, height, instancer height, scale, and tilt sliders from accepting values outside their configured ranges.

@OldDev78
OldDev78 requested review from a team September 13, 2026 18:12
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c831d410-2e0c-4a27-bfa2-914f25e68a91

📥 Commits

Reviewing files that changed from the base of the PR and between 2ab24bc and 27f0425.

📒 Files selected for processing (1)
  • modules/worldscape_3d/editor/ui/worldscape_3d_tools.cpp

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

WorldScape3D tool sliders now enforce configured value ranges. The size, strength, height, and slope controls also add UI spacing. Instancer height, scale, and tilt controls no longer accept out-of-range values.

Changes

WorldScape3D tool controls

Layer / File(s) Summary
Enforce tool ranges and spacing
modules/worldscape_3d/editor/ui/worldscape_3d_tools.cpp
Size, strength, height, slope, instancer height, scale, and tilt controls now use configured bounds or add spacers.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: arctis-fireblight, decryptedchaos

Merge Risk: ⚪ Minimal · up to 27f04

The updated controls prevent out-of-range terrain values without introducing a current merge-blocking issue.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: enforcing valid ranges for WorldScape3D tools. It is concise and specific.
Linked Issues check ✅ Passed For #1416, the terrain tool sliders no longer allow values outside their configured ranges. The size slider now enforces 0.1 to 200, and the height slider now enforces -500 to 500. The ins…
Out of Scope Changes check ✅ Passed The changes only update range-control flags in modules/worldscape_3d/editor/ui/worldscape_3d_tools.cpp. The changes apply to WorldScape3D tool inputs and support the linked issue's valid-input objec…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JoltedJon JoltedJon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Open

Development

Successfully merging this pull request may close these issues.

vers: 26.3.beta.1 | app crash&extreme system lag when editing large areas of terrain all at once

2 participants