Skip to content

MOD-15930 Use devcontainer distro for OS metadata#116

Merged
ofiryanai merged 1 commit into
masterfrom
devcontainer-os-metadata
Jun 1, 2026
Merged

MOD-15930 Use devcontainer distro for OS metadata#116
ofiryanai merged 1 commit into
masterfrom
devcontainer-os-metadata

Conversation

@ofiryanai

@ofiryanai ofiryanai commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Use /etc/devcontainer as the preferred source for the generated operating_systems metadata when a devcontainer image provides a DISTRO value.

Changes

  • Add /etc/devcontainer parsing in RAMP/module_metadata.py
  • Prefer DISTRO from /etc/devcontainer before falling back to the existing distro package detection
  • Add focused unit tests for devcontainer precedence and fallback behavior
  • Run the new unit test from tox.ini

Context

Redis module build images can expose the intended package platform in /etc/devcontainer while /etc/os-release may represent a lower-level compatibility base. RAMP should use the devcontainer platform metadata when available so generated module.json matches the platform used by the packaging environment.

Validation:

  • python3 -m unittest test_module_metadata.py
  • python3 -m py_compile RAMP/module_metadata.py test_module_metadata.py
  • git diff --check

@ofiryanai ofiryanai requested a review from alonre24 June 1, 2026 08:48
@ofiryanai ofiryanai merged commit 1e5c941 into master Jun 1, 2026
5 checks passed
@ofiryanai ofiryanai deleted the devcontainer-os-metadata branch June 1, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants