fix(rate-limit): non-overflowing token-refill computation#4
Merged
Conversation
After a long idle gap, elapsed/interval can exceed uint16; narrowing it (or the tokens_+new_tokens sum) to uint16 BEFORE the min() wraps it to a small value and defeats the cap. Compute in int64, clamp to max_tokens, then narrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the SDK correctness audit. After a long idle gap, narrowing
elapsed/interval(or thetokens_+new_tokenssum) to uint16 beforemin()wraps to a small value, defeating the token cap. Compute in int64, clamp to max_tokens, then narrow. 24/24 tests pass, lint clean.