fix(http): check curl_slist_append (silent header loss + leak on OOM)#18
Merged
Conversation
The README's FetchContent example pinned a superseded tag; consumers copy-pasting it pulled an older release than the current one. Point it at the latest tag (matches project VERSION in CMakeLists).
daily_requests_remaining() returned 0 when daily_limit<=0 ('no cap'), but
CDOClient::do_get() rejects with quota_exceeded when remaining<=0 — so
disabling the daily cap blocked EVERY request, contradicting the documented
'0 = no limit' semantics. Return INT32_MAX when disabled. Regression test in
NoDailyLimitWhenZero.
…on OOM) curl_slist_append returns nullptr on allocation failure WITHOUT freeing the existing list; assigning the result straight back to `headers` leaked the prior nodes and silently dropped headers. Capture, check, free + return a network error on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the SDK correctness audit.
curl_slist_appendreturns null on alloc failure without freeing the list; the old code reassigned the result, leaking prior nodes + dropping headers. Now checked: free + network error on failure. 174/174 tests pass, lint clean.