fix(ws): clamp int parsing (int32 overflow on malformed frames)#50
Merged
Conversation
The hand-rolled WS scanners accumulated into a bare int32 (`val=val*10+d`), which silently overflows (UB) on an out-of-range numeric field from a malformed/hostile frame. Both now accumulate in int64 with saturation and clamp to the int32 range, mirroring extract_dollar_cents. Regression test ExtractInt.OutOfRangeClampsInsteadOfOverflowing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the adversarially-verified SDK correctness audit.
extract_int+ theread_numorderbook lambda accumulated into a bare int32 → UB on out-of-range numeric fields from a malformed/hostile WS frame. Now int64-accumulate + saturate + clamp to int32 (mirrorsextract_dollar_cents). Regression test added. 165/165 tests pass, lint clean.