Repository navigation
Assign a maintainer directly (staff panel and admin) - #54
Merged
Merged
Conversation
When the owner already has an account there is no claim link to send.
Staff can now grant the listing on the spot, from the tool page's staff
panel or from the admin, with no claim to review and nothing emailed.
- `POST /catalog/staff/tools/<slug>/maintainers` takes `{email}` and
returns the listing's maintainers. Both it and the admin go through
`staff.assign_maintainer`.
- That writes the same approved `ToolClaim` a redeemed claim link does:
`claims.grant_listing` is factored out of `redeem_claim_invite`, with
the staff member as `reviewed_by`. A claim the account already filed is
approved in place rather than duplicated.
- An address that matches no account is refused with a pointer to the
claim link, and so is a deactivated account.
- Admin: **Tool claims → Add** picks a listing and an active account.
- Frontend: an "Add maintainer" field in the staff panel, above the
claim link minter. `make schema` regenerated the client.
- DEVELOPMENT.md describes the flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staff can make an existing account a maintainer of a listing with no claim to review:
POST /catalog/staff/tools/<slug>/maintainers, an Add maintainer field in the staff panel, and Tool claims → Add in the admin. All go throughstaff.assign_maintainer, which writes the same approvedToolClaima redeemed claim link does (claims.grant_listing). Unknown or deactivated accounts are refused with a pointer to the claim link.