Repository navigation
Add a rescore action, sending drafts from the web, and a Your activity page - #45
Merged
Merged
Conversation
…y page
A run is created Queued as soon as its PDF is uploaded, but nothing is queued
until the submitter sends the submission. A draft left behind therefore looked
like a task the worker had lost, and neither the submitter nor staff could move
it from the web.
Benchmarks:
- services.rescore re-queues every run of a submission that is scoring,
failed or awaiting review. It refuses drafts (sending is the submitter's
call) and decided submissions (a published result would change without
review). The submission admin gets a "Re-score" action over it.
- A draft's runs read "Not sent" instead of "Queued", in the admin and on
"Your submissions".
- "Your submissions" sends a draft that has runs ("Send for scoring"), through
the existing finalize endpoint.
Your activity (/activity, linked from the user menu):
- One page listing the account's benchmark submissions, listing claims, tools
submitted to the catalog, and listings maintained. Each section shows a
status and links to the page where the work is done.
- New GET /catalog/claims/mine (list_my_claims), the one list that had no
endpoint. It leaves out the editor's internal comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A production submission showed a run as Queued with no task behind it. It looked like the worker had lost the task, but the submission was a draft: a run is created Queued as soon as its PDF is uploaded, and nothing is queued until the submitter sends it. If the submit page is closed before "Send for scoring", the draft is stranded. Neither the submitter nor staff could move it from the web, and staff had no way to re-queue a submission whose task really was lost.
Benchmarks
services.rescore, staff only: re-queues every run of a submission that is Scoring, Scoring failed or Awaiting review. Scoring then moves it on, emails included. It refuses, saying why:finalizeendpoint.Your activity (
/activity)GET /api/v1/catalog/claims/mine(list_my_claims→useListMyClaims()); claims were the one list without one. It returnsToolClaimOutplustool_name, and leaves out the editor's internal comment.openapi.jsonand the generated client are regenerated.my-submissions.tsx(SUBMISSION_STATUS), so both pages use the same words.Not included:
Testing
Backend: full suite, 716 passed, including every benchmark test (this touches
apps/benchmarks/, so the Benchmarks workflow will also run here). New tests:Frontend: 884 passed, plus lint, format and typecheck. New tests:
The menu's keyboard test now counts the extra item.
In the browser:
/activityredirects a signed-out visitor to sign-in with the callback kept. The signed-in pages and the admin action are covered by tests but weren't checked in a browser.After deploy
The stuck
keptpdfsubmission is a draft. Re-score will refuse it, as intended; the submitter can now send it from "Your submissions".