Codex/replace miuihyperfocuslyriccontroller with live updates api - #16
Conversation
…r-with-live-updates-api
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d34b5d5e61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SwitchItem( | ||
| SettingProvider.adaptOriginalAndroidLyric, | ||
| "Adapt original Android Live Update lyric" | ||
| ) { SettingProvider.updateAdaptOriginalAndroidLyric(it) } |
There was a problem hiding this comment.
This adds a user-facing switch for adaptOriginalAndroidLyric, but the flag is never read anywhere in the playback path, so toggling it has no runtime effect. I verified with a repo-wide search that the value is only referenced in SettingProvider and this settings UI, while PlaybackService still calls LiveUpdateLyricController.updateLyric(...) unconditionally. Users will see a control that appears functional but cannot change behavior.
Useful? React with 👍 / 👎.
| fun updateAdaptOriginalAndroidLyric(newStatus: Boolean){ | ||
| adaptOriginalAndroidLyric = newStatus | ||
| CoroutineScope(Dispatchers.IO).launch { | ||
| DataStoreManager.setBooleanItem("adaptOriginalAndroidLyric", adaptOriginalAndroidLyric) | ||
| } |
There was a problem hiding this comment.
The new setter persists adaptOriginalAndroidLyric to DataStore, but initSetting() never reads that key back, so the value always falls back to false after app restart. This means the switch state is not durable across launches even though it is written to storage, which will confuse users and makes the preference unreliable.
Useful? React with 👍 / 👎.
1 participant
No description provided.