infra: Update dv_for_data_source to create the dv from public quay#5592
infra: Update dv_for_data_source to create the dv from public quay#5592RoniKishner wants to merge 1 commit into
Conversation
Signed-off-by: rkishner <rkishner@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe test updates DataVolume creation to use Fedora registry sources, removes Artifactory resource handling, applies Fedora DV sizing, and shortens unchanged referenced-volume verification to five minutes. ChangesGolden image data source updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsRepository analysis: Couldn't refresh Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
📌 Additional InformationCustom Commands:
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
requested review from
dshchedr,
mijankow and
rnetser
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
/test-plan |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr diff 5592 --repo RedHatQE/openshift-virtualization-tests > /tmp/pr.diff
echo "---- FILES CHANGED ----"
gh pr diff 5592 --repo RedHatQE/openshift-virtualization-tests --name-only
echo "---- DIFF ----"
cat /tmp/pr.diffLength of output: 2270 🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr diff 5592 --repo RedHatQE/openshift-virtualization-tests --name-only
echo "---- DIFF ----"
gh pr diff 5592 --repo RedHatQE/openshift-virtualization-testsLength of output: 2207
Based on the PR objectives alone (without being able to inspect the actual diff/fixtures/markers), I can note:
Please check the sandbox's Git credentials/token configuration for this repository so I can retry cloning and produce the full inline Test Execution Plan. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/verified |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "---- AUTH STATUS ----"
gh auth status 2>&1 || true
echo "---- PR DIFF ----"
gh pr diff 5592 --repo RedHatQE/openshift-virtualization-tests --name-only 2>&1 || true
gh pr diff 5592 --repo RedHatQE/openshift-virtualization-tests 2>&1 || true
echo "---- LOCAL FILE CHECK ----"
fd test_ssp_data_sources.pyLength of output: 2355
Additionally, I should clarify: this chat-based response channel can only produce a text reply in this comment thread; it cannot submit a separate inline review comment on a specific diff line of the "Files Changed" tab. Posting an inline PR review comment requires the dedicated review flow (e.g., triggered via Given the PR objectives, here's the best-effort plan without repository access: Test Execution Plan
Real tests (cluster required) — recommended since this changes runtime image-pull behavior:
Please check the sandbox's Git credentials/token configuration for ✅ Action performedFull review finished. |
| source_dict=construct_datavolume_source_dict(source=REGISTRY_STR, url=DEFAULT_FEDORA_REGISTRY_URL), | ||
| size=Images.Fedora.DEFAULT_DV_SIZE, |
There was a problem hiding this comment.
Wouldn't it be better to clone from a golden image to reduce the dependency on quay?
There was a problem hiding this comment.
You mean from a DataSource?
It's not possible, the test idea is to create a DV while the boot sources are down, and then to bring them up again after the PVC is created.
So there no source to clone from when creating the DV.
6 participants
What this PR does / why we need it:
dv_for_data_sourceintest_ssp_data_sources.pyto create theDataVolumefrom a public Quay registry (using Images.Fedora via DEFAULT_FEDORA_REGISTRY_URL) instead of an Artifactory-hosted HTTP image, removing the dependency on Artifactory.DataSourcedoes not change reference, since the testing environments are more stable now and can manage to finish the import in less then 5 minutes.Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-86274
Summary by CodeRabbit