update: expand storage migration hotplug test to 4-disk conformance (CNV-88911)#5569
update: expand storage migration hotplug test to 4-disk conformance (CNV-88911)#5569Ahmad-Hafe wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe storage migration tests now create three hotplugged disks, attach and mount them on a Fedora VM, write test files to each mount, and verify their contents after migration. ChangesMulti-disk hotplug storage migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
092428d to
d2e1228
Compare
d2e1228 to
320889f
Compare
320889f to
0a5e2f8
Compare
0a5e2f8 to
539ef14
Compare
|
Tip For best results, initiate chat on the files or code changes.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/storage/storage_migration/utils.py`:
- Around line 77-95: Update verify_files_in_hotplugged_disks to inspect every
path in MOUNT_HOTPLUGGED_DEVICE_PATHS before asserting. Collect each mount’s
mismatch details while continuing the loop, then perform one final assertion
that reports all accumulated mismatches together; preserve successful
verification when no mismatches are found.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 129b2ddb-3bfc-42bb-af08-9b4d9a43a483
📒 Files selected for processing (4)
tests/storage/storage_migration/conftest.pytests/storage/storage_migration/constants.pytests/storage/storage_migration/test_storage_class_migration.pytests/storage/storage_migration/utils.py
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
RedHatQE/openshift-virtualization-tests-design-docs(manual)
|
Clean rebase detected — no code changes compared to previous head ( |
|
/verified |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes.
|
|
D/S test |
|
D/S test |
|
Clean rebase detected — no code changes compared to previous head ( |
|
D/S test |
|
/build-and-push-container |
|
D/S test |
|
Clean rebase detected — no code changes compared to previous head ( |
|
Clean rebase detected — no code changes compared to previous head ( |
|
D/S test |
|
Clean rebase detected — no code changes compared to previous head ( |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5569 published |
|
/lgtm |
|
verify-bugs-are-open is failing and will be addressed inhttps://github.com//pull/5606 |
…CNV-88911) Signed-off-by: Ahmad Hafe <ahafe@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Clean rebase detected — no code changes compared to previous head ( |
|
rebased for verify-bugs-are-open is now fixed |
|
/verified also executed 30 times in executor runner pass rate 100% |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes.
Please re-trigger |
What this PR does / why we need it:
Modifies
TestStorageClassMigrationWithVolumeHotplugto meet the conformance requirement:"Storage live migrates a VM with 4 disks, between two storage classes of the same provider"
Changes:
fedora_vm_body/ quay.io) with golden image DataSource for the boot disk — removes external registry dependency, enabling self-validation@pytest.mark.conformancemarkerDetails:
fedora_vm_for_hotplug_and_storage_migration) now usesdata_volume_template_with_source_ref_dictwith a golden image DataSource, matching the pattern of other VM fixtures in the filecreate_dvwithcontextlib.ExitStackto manage multiple context managers in a loopvirtctl_volumewithExitStackfor the same reasonHOTPLUGGED_DEVICE,MOUNT_HOTPLUGGED_DEVICE_PATH) andverify_file_in_hotplugged_diskreplaced with plural equivalents generated fromNUM_HOTPLUG_DISKSTestStorageClassMigrationAtoB,TestStorageClassMigrationWindowsWithVTPM) — they still use artifactory as beforeWhich issue(s) this PR fixes:
Special notes for reviewer:
The test has no external registry dependencies (no quay.io, no artifactory). It uses only golden images (already on the cluster) and blank DataVolumes, making it suitable for self-validation runs.
jira-ticket:
https://redhat.atlassian.net/browse/CNV-88911
Summary by CodeRabbit