Repository navigation
fix: create /var/tmp/rhc if missing - #467
Merged
Merged
Conversation
Archana-PandeyM
marked this pull request as draft
June 4, 2026 09:46
Archana-PandeyM
force-pushed
the
arpandey/fix-createCollectorTmpDir
branch
from
June 4, 2026 11:30
b8c96a8 to
663b7c3
Compare
Archana-PandeyM
marked this pull request as ready for review
June 4, 2026 11:34
Archana-PandeyM
force-pushed
the
arpandey/fix-createCollectorTmpDir
branch
3 times, most recently
from
June 9, 2026 09:11
641b79e to
91bb264
Compare
stephenbourke
approved these changes
Jun 9, 2026
stephenbourke
left a comment
stephenbourke
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just needs a rebase.
* Card Id: CCT-2534 Create /var/tmp/rhc with root-only permissions before creating the collector-specific temporary directory. This prevents rhc-collector from failing when the parent directory does not already exist. Signed-off-by: Archana Pandey <arpandey@redhat.com>
Archana-PandeyM
force-pushed
the
arpandey/fix-createCollectorTmpDir
branch
from
June 10, 2026 08:21
91bb264 to
091a0e5
Compare
|
This ended up breaking bootc because our container export flow requires that all content have a SELinux label defined. See bootc-dev/bootc#2395 (which I ended up rolling into another PR). A few things here. First, hardcoded file names in You added a tmpfiles.d config, which is fine. But why do you have a hardcoded tmpdir at all? You should have a randomly named tmpdir like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create /var/tmp/rhc with root-only permissions before creating the collector-specific temporary directory. This prevents rhc-collector from failing when the parent directory does not already exist.