[rhel-8-egg] feat(test): Add selinux_context=None for user-invoked functionality tests#516
Merged
Merged
Conversation
…ests Accommodate changes to InsightsClient.run() which now uses runcon by default to execute insights-client with insights_client_t SELinux context, matching production systemd behavior. Updated user-invoked functionality tests to use selinux_context=None: - test_version.py: --version command (1 call) - test_client_options.py: --support, --validate, and unregistered --diagnosis (3 calls) - test_connection.py: all --test-connection calls (5 calls) - test_status.py: all --status calls (3 calls) - test_motd.py: --status calls for MOTD testing (2 calls) - test_collection.py: --verbose for timeout configuration testing (1 call) Production/service functionality tests (registration, upload, compliance, data collection) retain default SELinux context to match systemd behavior. This ensures tests properly differentiate between user-invoked commands and production service operations while maintaining comprehensive coverage of both scenarios. Message Created by Cursor (calude-4-sonnet)
pkoprda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accommodate changes to InsightsClient.run() which now uses runcon by default to execute insights-client with insights_client_t SELinux context, matching production systemd behavior.
Updated user-invoked functionality tests to use selinux_context=None:
Production/service functionality tests (registration, upload, compliance, data collection) retain default SELinux context to match systemd behavior.
This ensures tests properly differentiate between user-invoked commands and production service operations while maintaining comprehensive coverage of both scenarios.
Message Created by Cursor (calude-4-sonnet)
This pull request is a backport of: #461