Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

adding no_log: true to avoid leaking redhat_portal_password#13

Open
vladi-k wants to merge 1 commit into
RedHatInsights:masterfrom
vladi-k:insights-config-nolog
Open

adding no_log: true to avoid leaking redhat_portal_password#13
vladi-k wants to merge 1 commit into
RedHatInsights:masterfrom
vladi-k:insights-config-nolog

Conversation

@vladi-k

@vladi-k vladi-k commented Feb 13, 2020

Copy link
Copy Markdown

Without this a malicious user can potentially see redhat_portal_password in clear text in ansible-playbook output or logs

Signed-off-by: Vladimir Vasilev <vvasilev@redhat.com>
@vladi-k
vladi-k requested a review from Jason-RH February 13, 2020 09:45
@nicholasburr

Copy link
Copy Markdown

I see that the insights_config module is printing the last valid variable. This should be reported as a bug in the module since anyone using it will encounter this issue.

- name: Insights playbook
  hosts: all
  roles:
  - role: redhatinsights.insights-client
    vars:
    - redhat_portal_username: username
    - redhat_portal_password: password


    "invocation": {
        "module_args": {
            "allow_no_value": false,
            "attributes": null,
            "backup": false,
            "content": null,
            "create": true,
            "delimiter": null,
            "directory_mode": null,
            "follow": false,
            "force": null,
            "group": null,
            "mode": null,
            "no_extra_spaces": true,
            "option": "password",
            "owner": null,
            "path": "/etc/insights-client/insights-client.conf",
            "regexp": null,
            "remote_src": null,
            "section": "insights-client",
            "selevel": null,
            "serole": null,
            "setype": null,
            "seuser": null,
            "src": null,
            "state": "present",
            "unsafe_writes": null,
            "value": "password"
        }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants