fix(error-book): avoid full reload and invalid pagination after deleting records - #1067
Open
lihongzy wants to merge 1 commit into
Open
fix(error-book): avoid full reload and invalid pagination after deleting records #1067lihongzy wants to merge 1 commit into
lihongzy wants to merge 1 commit into
Conversation
|
@lihongzy is attempting to deploy a commit to the Kai's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mapfor grouping to reduce unnecessary overheadWhy
Previously, deleting a record in ErrorBook triggered a full reload and regrouped all records from scratch.
It could also leave the current page out of range after deleting the last item on the last page.
Scope
Only updates
src/pages/ErrorBook/index.tsx.