PR: Fix TimerObservable(==) comparing delay against itself - #84
Merged
bvdmitri merged 2 commits intoAug 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 78.45% 78.42% -0.03%
==========================================
Files 120 120
Lines 3829 3829
==========================================
- Hits 3004 3003 -1
- Misses 825 826 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Maintainer note: added a regression test ( |
bvdmitri
self-requested a review
August 10, 2026 10:32
bvdmitri
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: issue-01
Summary
getdelay_ms(t1) == getdelay_ms(t1)on the right-hand side of the second operand is acopy-paste typo; the delay is never compared with
t2. Fix the comparison togetdelay_ms(t2).Change
src/observable/timer.jlHow to verify
Add the first assertion to
test/observable/test_observable_timer.jlto lock it in.Closes #69