Fix FBX export race conditions#6
Open
robslove wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds synchronization and safer working-directory handling around FBX export to avoid cross-thread/process-wide side effects during export.
Changes:
- Introduced a shared export lock to serialize exports.
- Wrapped
Directory.SetCurrentDirectory(...)usage intry/finallyto guarantee restoration of the previous working directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| public static partial class Fbx | ||
| { | ||
| private static readonly object ExportLock = new object(); |
Comment on lines
+33
to
+60
| lock (ExportLock) | ||
| { | ||
| dir.Create(); | ||
| } | ||
| var file = new FileInfo(path); | ||
| var dir = file.Directory; | ||
|
|
||
| var currentDir = Directory.GetCurrentDirectory(); | ||
| Directory.SetCurrentDirectory(dir.FullName); | ||
| if (!dir.Exists) | ||
| { | ||
| dir.Create(); | ||
| } | ||
|
|
||
| var name = Path.GetFileName(path); | ||
| var currentDir = Directory.GetCurrentDirectory(); | ||
| try | ||
| { | ||
| Directory.SetCurrentDirectory(dir.FullName); | ||
|
|
||
| using (var exporter = new FbxExporter(name, imported, exportOptions)) | ||
| { | ||
| exporter.Initialize(); | ||
| exporter.ExportAll(); | ||
| } | ||
| var name = Path.GetFileName(path); | ||
|
|
||
| Directory.SetCurrentDirectory(currentDir); | ||
| using (var exporter = new FbxExporter(name, imported, exportOptions)) | ||
| { | ||
| exporter.Initialize(); | ||
| exporter.ExportAll(); | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| Directory.SetCurrentDirectory(currentDir); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Added a global lock in Fbx.cs (Export(string, IImported, ExportOptions)) to serialize FBX export execution.
• Wrapped working-directory switching with try/finally to always restore the previous directory.
Why
• FBX export was running from parallel callers while using Directory.SetCurrentDirectory(...) (process-wide state), causing race conditions.
• This reduces native FBX initialization/export instability (AccessViolationException) seen during concurrent exports.