test(db_get): multi-table root shares one root symfile#241
Merged
Conversation
The three flat splayed tables (Trades/Quotes/Returns) under one root each created a private per-table symfile for the same vocabulary. Multi-table roots follow the client layout: one root symfile shared via the explicit sym argument, so cross-table SYM ops stay on the same-domain fast path. Asserts exactly one symfile exists at the root and none per table dir; the overwrite-heal re-set appends to the shared vocabulary instead of reseeding a private one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three flat splayed tables (Trades/Quotes/Returns) under one root
each created a private per-table symfile for the same vocabulary.
Multi-table roots follow the client layout: one root symfile shared
via the explicit sym argument, so cross-table SYM ops stay on the
same-domain fast path instead of re-encoding positions between
per-table domains.
Asserts exactly one symfile exists at the root and none per table
dir; the overwrite-heal re-set appends to the shared vocabulary
instead of reseeding a private one.
Audited the rest of the rfl suite for the same pattern: parted
fixtures already share the partition root's symfile by convention
(date, integer, and dotted segments all verified), and the remaining
multi-symfile tests exercise symfile mechanics deliberately
(sym_coverage, db_sym_resolution, shared_sym_domain,
part_mixed_width, csv_splayed, system_branch_cov) — left untouched.