fix: verify release source before artifacts - #13
Merged
Conversation
What changed: - split immutable release checkout from image-reference download - enforce source-manifest verification before generated artifacts exist - update the deterministic source manifest Why: - scheduled security scans failed because downloaded release evidence polluted the source inventory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The scheduled security workflow downloaded
artifacts/image-reference.txtbefore runninggenerate-source-manifest.py --check. The manifest intentionally inventories all files in the source tree, so the generated release artifact made a clean release checkout fail verification.Validation
git diff --checkpassconcurrency.queuesyntax false positiveScope
Workflow and contract-test only. No image, database runtime, release tag, or published digest changes.