fix: Make IDs of comment bar buttons consistent - #10280
Open
gonfunko wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR makes the ID of comment bar button objects consistent with value of the
idattribute of their focusable elements. Previously, the ID of the objects was identical to that of their parent comment, and different from theidattribute of their representation in the DOM. It also makes theidfield publicly accessible.In addition to making things more consistent and sensible, this also lays the groundwork for making these buttons focusable in block comments in Scratch; core Blockly only uses them in workspace comments, and hardcodes that logic in
WorkspaceSvg's implementation oflookupFocusableNode(). With consistent (and public) IDs, they could be registered with the workspace'sComponentManageras having theFOCUSABLEcapability, and the node resolution inlookupFocusableNode()would work. I actually plan to do another refactor to replace the entirety oflookupFocusableNode()'s implementation in core to depend on theComponentManager, as doing so would make all lookups constant-time and thereby resolve #9162, along with making the code much simpler.