qt: remove leftover empty widget from Asset Info panel (#395)#455
Open
JSanchezFDZ wants to merge 1 commit into
Open
qt: remove leftover empty widget from Asset Info panel (#395)#455JSanchezFDZ wants to merge 1 commit into
JSanchezFDZ wants to merge 1 commit into
Conversation
The Assets dialog carried a `QListWidget` ("listWidget") in the bottom-right
of the Asset Info area that was never populated or referenced from any code —
its only traces were the .ui definition and a dead stylesheet rule. With a
fixed 380px minimum width it rendered as an empty box (most visibly on the
Windows Qt build).
Remove the orphan widget and its stylesheet rule. No code references it, so
nothing else changes.
c8ac0eb to
f0f9739
Compare
Author
|
Hi @CodeIsTheKey @npq7721 @nandofw — when any of you have a moment (no rush), I'd appreciate a look at a small batch of focused fixes I've opened against
All are small and backward-compatible, and I've left ACKs on a few of the open community PRs too. Happy to squash, rebase, or adjust anything. Thanks for maintaining this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Assets dialog shows an empty box in the bottom-right of the Asset Info
area (most visibly on the Windows Qt build) — issue #395.
Root cause
src/qt/forms/assetsdialog.uidefines aQListWidgetnamedlistWidgetthatis never populated or referenced from any source file. Its only traces are the
.ui definition and a dead
QDialog#AssetsDialog QListWidget#listWidgetrule ingeneral.css. Because it has a fixedminimumSizewidth of 380px and anexpanding size policy, it reserves space and renders as an empty widget.
Fix
Remove the orphan widget from the .ui and its dead stylesheet rule. Verified
that no code references
listWidget(grepacrosssrc/qt), and the .uiremains well-formed XML after the removal.
Closes #395.