Entering optional fee addresses for assets.#437
Conversation
- Add BootstrapManager class for automatic blockchain bootstrap - Downloads bootstrap.zip and powcache.dat on first start - Fix build errors: -Woverloded-virtual typo in configure.ac - Fix missing includes in bip32.h and lockedpool.cpp - Fix missing ENABLE_WALLET guards in rpcassets.cpp Test on Ubuntu 24.04.4 LTS
JSanchezFDZ
left a comment
There was a problem hiding this comment.
Reviewed the optional asset fee-address feature.
-
Scope / duplicate. This PR's head (eb4a1ea) is the same commit as #438, so
it also contains the entire auto-bootstrap downloader pluslockedpool.cpp,
bip32.h, and.gitignorechanges. The actual fee-address change is only part
ofrpc/rpcassets.cpp. Please rebase so this PR contains just thefeeAddress
feature and close/separate #438 — otherwise the (security-sensitive) bootstrap
code blocks an otherwise small asset feature. Thebip32.h <cstdint>and
lockedpool.cpp <stdexcept>additions are legitimate build fixes but unrelated;
fine to keep, but please call them out or split them. -
Feature itself. The approach across createasset/sendasset/mintasset
(DecodeDestination+IsValidDestination,coinControl.destChange = feeDest,
manual selection offeeDestUTXOs,fAllowOtherInputs = false) reads
reasonably. Two things to confirm:- With
fAllowOtherInputs = falseand onlyfeeDestUTXOs selected, please
verify the asset funding inputs/outputs still resolve for all three RPCs — a
feeAddressthat holds RTM but where the asset/owner outputs would need other
inputs could fail in a way users won't expect. - The "no spendable UTXOs on feeAddress" path throws
RPC_WALLET_INSUFFICIENT_FUNDS, which is good; a functional test covering
that path and "change returns to feeAddress" would make this much easier to
merge with confidence.
- With
Optional fee addresses have been added to all asset instructions in the Raptoreum CLI.
An asset change address has been added specifically for sendasset.