Fix typo in compiler flag (-Woverloded-virtual → -Woverloaded-virtual)#432
Open
Germardies wants to merge 1 commit into
Open
Fix typo in compiler flag (-Woverloded-virtual → -Woverloaded-virtual)#432Germardies wants to merge 1 commit into
Germardies wants to merge 1 commit into
Conversation
Fix typo: -Woverloded-virtual → -Woverloaded-virtual in configure.ac
JSanchezFDZ
approved these changes
Jun 22, 2026
JSanchezFDZ
left a comment
JSanchezFDZ
left a comment
There was a problem hiding this comment.
Verified the fix. AX_CHECK_COMPILE_FLAG probes -Woverloaded-virtual, but the
success branch was appending the misspelled -Woverloded-virtual to
WARN_CXXFLAGS, which GCC then rejects with unrecognized command-line option,
breaking the build on modern toolchains. The one-character correction makes the
appended flag match the probed one. Correct and complete. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a build error caused by a misspelled compiler warning flag
(-Woverloded-virtual → -Woverloaded-virtual) in configure.ac.
The incorrect flag prevents compilation on modern GCC versions:
g++: error: unrecognized command-line option '-Woverloded-virtual'
This change corrects the flag and restores compatibility. Build tested on Ubuntu 22.04.