Fix release APK build break in SwipeHelper - #98
Merged
Conversation
Co-authored-by: dbochicchio <31511185+dbochicchio@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to unblock the build-release-apk GitHub Actions job by fixing a compile-time issue in the swipe gesture evaluation logic used by the app’s touch handling (the SwipeHelper that drives swipe-triggered relay/MQTT behavior).
Changes:
- Introduces a
PINCH_SPREAD_RATIO_THRESHOLDconstant to replace the previously missing/undefined pinch-spread threshold reference. - Fixes the two-pointer pinch/spread rejection block by explicitly defining
p0before computing pointer spread deltas. - Updates the related inline comment to reference the new constant name.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-release-apk
Fix release APK build break in SwipeHelper
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-release-apkworkflow was failing in:app:compileReleaseJavaWithJavacdue to unresolved symbols introduced in the multi-touch swipe path. This change restores the missing two-finger gesture state used by the pinch/spread guard so release builds can compile again.Build failure root cause
p0pointer reference in the two-finger swipe evaluation branch.Swipe gesture path