Skip to content

#79 Color Mixer: all HSL bands per tab and a weighted image-drag pipette #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yojen7 merged 25 commits into from
Oct 4, 2026
Merged

#79 Color Mixer: all HSL bands per tab and a weighted image-drag pipette #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b22ec51
feat(color): add expanded color mixer with targeted pipette
lalibertemarc Oct 1, 2026
edc753b
refactor(color): drop pipette slider highlight
lalibertemarc Oct 1, 2026
244d197
perf(color): remove lag between pipette drag and mixer sliders
lalibertemarc Oct 1, 2026
67966c7
Color mixer pipette: adapt to RapidRoom's shader, undo and image swit…
claude Oct 4, 2026
487f43b
Change list and credits: expanded Color Mixer with targeted pipette (…
claude Oct 4, 2026
8830dc0
feat(adjustments): add visibility toggles for color grading and mixer
lalibertemarc Oct 1, 2026
2c46f15
Treat a missing section visibility key as visible when toggling
claude Oct 4, 2026
ba8c6f2
Change list and credits: Color Grading / Color Mixer visibility toggles
claude Oct 4, 2026
9fea0f5
Lights Out viewing in Library and Editor
Oct 4, 2026
bbcab30
Change list and credits: Lights Out (#83)
claude Oct 4, 2026
a7825a5
Test colour tool visibility: absent keys, independent tools, parent eye
claude Oct 4, 2026
0b5c037
Merge current main into color-tool visibility verification
yojen7 Oct 4, 2026
57b1453
Expose visibility controls to keyboard and screen-reader users
yojen7 Oct 4, 2026
3380f88
Merge current integration into Lights Out verification
yojen7 Oct 4, 2026
334f8ec
Merge verified catalog develop import before color-tool visibility va…
yojen7 Oct 4, 2026
4871aa1
Regenerate status docs after catalog and color-tool integration
yojen7 Oct 4, 2026
cb721d1
Serialize Lights Out fullscreen changes to preserve window state
yojen7 Oct 4, 2026
282edc4
Merge verified catalog import into Lights Out validation stack
yojen7 Oct 4, 2026
998e7ed
Apply Lights Out to Reference View backgrounds and chrome
yojen7 Oct 4, 2026
6104b1c
Match pipette band weights to current perceptual HSL shader
yojen7 Oct 4, 2026
6e54bd3
fix: type Lights Out shortcut state
yojen7 Oct 4, 2026
be84a4c
Merge verified catalog, visibility and Lights Out integrations
yojen7 Oct 4, 2026
2acbe86
Merge branch 'codex/verify-104' into codex/verify-98
yojen7 Oct 4, 2026
9c611b5
fix: end mixer picking when the tool is bypassed
yojen7 Oct 4, 2026
e85f200
style: format integrated HSL picker
yojen7 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ RapidRAW is a free, open-source raw editor by [Timon Käch (CyberTimon)](https:/
- **Bring your Lightroom edits along:** import XMP sidecars
- **Pick and reject flags for culling,** separate from stars: P, X and U as in Lightroom, a flag filter, and rejects that darktable, Bridge and Lightroom understand.
- **Presets at your fingertips.** Presets sit in the left sidebar as compact rows: hover to preview one on your photo, click to apply, and star favorites to pin them on top.
- **Lights Out, Lightroom-style.** Press L to dim everything but the photo, again for pure black, Escape to come back. Good for judging night shots.
- **Targeted colour adjustment.** Pick Hue, Saturation or Luminance in the expanded Color Mixer, then drag up or down on a colour in the photo to change just the bands it contains.

53 improvements on top of RapidRAW so far, including fixes for 18 upstream issues that are still open there. Every change, with its source and upstream status, is in the [changelog](../CHANGES.md).
56 improvements on top of RapidRAW so far, including fixes for 18 upstream issues that are still open there. Every change, with its source and upstream status, is in the [changelog](../CHANGES.md).
<!-- rapidroom-changes:end -->

## Why RapidRoom
Expand Down
32 changes: 31 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Everything RapidRoom adds on top of upstream [RapidRAW](https://github.com/Cyber

<sub>Generated from [rapidroom/changes.json](rapidroom/changes.json) by `node rapidroom/status.mjs`; don't edit by hand.</sub>

**53 changes on top of RapidRAW.** 19 fix upstream issues that had been open a median of 63 days when RapidRoom shipped the fix; 18 of them still open upstream. 14 offered upstream as PRs, 3 merged so far.
**56 changes on top of RapidRAW.** 19 fix upstream issues that had been open a median of 63 days when RapidRoom shipped the fix; 18 of them still open upstream. 14 offered upstream as PRs, 3 merged so far.

| Change | Type | By | Upstream |
| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------- | ------------------------------------------------------------------------------------------------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
Expand Down Expand Up @@ -64,6 +64,9 @@ Everything RapidRoom adds on top of upstream [RapidRAW](https://github.com/Cyber
| Import old Lightroom `.lrtemplate` presets stored as plain Lua tables, without running any Lua | feature | [@laurensiusadi](https://github.com/laurensiusadi) | not yet offered |
| Pick and reject flags, separate from star ratings: P / X / U shortcuts, badges, a flag filter (picked, unflagged, hide rejected, rejected) and Delete rejected | feature | [@lalibertemarc](https://github.com/lalibertemarc), [@yojen7](https://github.com/yojen7) | [#1599](https://github.com/CyberTimon/RapidRAW/issues/1599); [#994](https://github.com/CyberTimon/RapidRAW/issues/994); [#1057](https://github.com/CyberTimon/RapidRAW/issues/1057) |
| Presets move to the left sidebar with compact rows, hover previews, favorites and folder reordering | feature | [@laurensiusadi](https://github.com/laurensiusadi) | not yet offered |
| Color Grading and Color Mixer get their own visibility eye, globally and in masks; the Color panel eye still bypasses every colour tool | feature | [@lalibertemarc](https://github.com/lalibertemarc) | PR [#1833](https://github.com/CyberTimon/RapidRAW/issues/1833) |
| Lights Out viewing in Library and Editor: L cycles Normal → Dim → Black, Shift+L goes back, Escape restores | feature | [@zeromeridian](https://github.com/zeromeridian), [@yojen7](https://github.com/yojen7) | not yet offered |
| Expanded Color Mixer: Hue, Saturation and Luminance tabs with all eight bands, and a pipette that adjusts the bands under the cursor as you drag up or down on the photo | feature | [@lalibertemarc](https://github.com/lalibertemarc) | not yet offered |

⚑ changes rendered output on purpose. Upstream status as of 2026-10-04.

Expand Down Expand Up @@ -530,3 +533,30 @@ Everything RapidRoom adds on top of upstream [RapidRAW](https://github.com/Cyber
- **Upstream:** not yet offered
- **Commits:** [9535884](https://github.com/laurensiusadi/RapidRAW/commit/953588443099def3fd0c5e92a55e1966d994e385), [9e478b6](https://github.com/laurensiusadi/RapidRAW/commit/9e478b66eeee63be3e79238af708916655f52125)
- **Notes:** Hovering a preset previews it on the image without touching the edit, its history or sidecars; only a click applies it. Saved workspaces keep their layout: Presets only moves when it is still in its old default spot on the right. Preset preview thumbnails are gone. Enter/Space apply a focused preset. Scrollbar thumbs across the app are more subtle.

### Color Grading and Color Mixer get their own visibility eye, globally and in masks; the Color panel eye still bypasses every colour tool

- **Type:** feature
- **Landed in RapidRoom:** 2026-10-04
- **By:** [@lalibertemarc](https://github.com/lalibertemarc), from lalibertemarc/RapidRAW
- **Upstream:** PR [#1833](https://github.com/CyberTimon/RapidRAW/issues/1833)
- **Commits:** [879b414](https://github.com/lalibertemarc/RapidRAW/commit/879b4146fa4d87ecfa3580261cfc0554ffb1555f)
- **Notes:** New sectionVisibility.colorGrading/colorMixer keys default to on, so existing sidecars and presets render unchanged; turning a tool off intentionally skips it. Resetting or pasting the Color section re-enables both tools.

### Lights Out viewing in Library and Editor: L cycles Normal → Dim → Black, Shift+L goes back, Escape restores

- **Type:** feature
- **Landed in RapidRoom:** 2026-10-04
- **By:** [@zeromeridian](https://github.com/zeromeridian), [@yojen7](https://github.com/yojen7), from zeromeridian/RapidRAW-Enhanced
- **Upstream:** not yet offered
- **Commits:** [69bdb28](https://github.com/zeromeridian/RapidRAW-Enhanced/commit/69bdb283246c7c6746f88c7c0c22d88b7e90ae94)
- **Notes:** Only the app chrome around the photo is dimmed or hidden; the preview and exports are untouched. Toggle folder tree moved from L to N to free the key. Black also switches the window to fullscreen and restores it afterwards. Local Codex review integrates Reference View and pick/reject controls, and serializes native fullscreen entry/restore to preserve the original window state during rapid mode changes; six async tests cover cancellation, restore races and native failures.

### Expanded Color Mixer: Hue, Saturation and Luminance tabs with all eight bands, and a pipette that adjusts the bands under the cursor as you drag up or down on the photo

- **Type:** feature
- **Landed in RapidRoom:** 2026-10-04
- **By:** [@lalibertemarc](https://github.com/lalibertemarc), from lalibertemarc/RapidRAW
- **Upstream:** not yet offered
- **Commits:** [b5475ad](https://github.com/lalibertemarc/RapidRAW/commit/b5475ad8e3176386153d8c3a8fbdc7d21ba7c5a9), [dffc46a](https://github.com/lalibertemarc/RapidRAW/commit/dffc46a161f6a9c35037348d9d62b1a5267a99ac), [17173f2](https://github.com/lalibertemarc/RapidRAW/commit/17173f2873b44f4f7d5f219df1e5e744b3e0dfa9)
- **Notes:** HSL math and defaults are unchanged; the pipette only sets the existing mixer sliders. Each band moves in proportion to how much of it is in the sampled square (dominant band 0.5 per pixel, Alt for fine steps), weighted by the current shader's perceptual sRGB hue and saturation, with its linear neutral gate. A drag is one undo step. Global mixer only, not masks. Adapted with Claude Code. Local Codex review aligns sampling with the post-sync shader and stops the gesture when the parent Color or Color Mixer eye is off; no render math changes.
3 changes: 3 additions & 0 deletions CREDITS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,11 @@ RapidRoom is built on other people's work. This file lists where every non-upstr
| Lua-table `.lrtemplate` preset import | [@laurensiusadi](https://github.com/laurensiusadi) (Laurensius Adi), adapted with Claude Code | [laurensiusadi/RapidRAW@bb60210](https://github.com/laurensiusadi/RapidRAW/commit/bb60210c609c6939d34deba9c1043fe9d01bde92) |
| Pick and reject flags | [@lalibertemarc](https://github.com/lalibertemarc), adapted by @yojen7 with Claude Code | [lalibertemarc/RapidRAW@1b4b9db](https://github.com/lalibertemarc/RapidRAW/commit/1b4b9db115f0c1aa6f12e2b4bc0515ffb7fb0eb6) |
| Presets sidebar with hover previews, favorites, folder reordering | [@laurensiusadi](https://github.com/laurensiusadi) (Laurensius Adi), adapted by Claude Code | [9535884](https://github.com/laurensiusadi/RapidRAW/commit/953588443099def3fd0c5e92a55e1966d994e385), [9e478b6](https://github.com/laurensiusadi/RapidRAW/commit/9e478b66eeee63be3e79238af708916655f52125) in laurensiusadi/RapidRAW |
| Separate visibility toggles for Color Grading and Color Mixer | [@lalibertemarc](https://github.com/lalibertemarc) with Claude | [lalibertemarc/RapidRAW@879b414](https://github.com/lalibertemarc/RapidRAW/commit/879b4146fa4d87ecfa3580261cfc0554ffb1555f) (upstream PR `CyberTimon/RapidRAW#1833`) |
| Lights Out viewing (L / Shift+L) | Emil Zimmermann ([zeromeridian](https://github.com/zeromeridian)), adapted with Claude Code | [zeromeridian/RapidRAW-Enhanced@69bdb28](https://github.com/zeromeridian/RapidRAW-Enhanced/commit/69bdb283246c7c6746f88c7c0c22d88b7e90ae94) |

| Lightroom catalog photo-edit previews and selective develop/virtual-copy import | [@laurensiusadi](https://github.com/laurensiusadi) (Laurensius Adi), adapted by yojen7 with Codex | [laurensiusadi/RapidRAW@dda6cc5](https://github.com/laurensiusadi/RapidRAW/commit/dda6cc51c69dc6a17906609dbb667eff3507aeeb); shares the existing catalog reader and XMP mapper |
| Expanded Color Mixer with a targeted pipette | [@lalibertemarc](https://github.com/lalibertemarc), adapted with Claude Code | [lalibertemarc/RapidRAW@b5475ad](https://github.com/lalibertemarc/RapidRAW/commit/b5475ad8e3176386153d8c3a8fbdc7d21ba7c5a9), [@dffc46a](https://github.com/lalibertemarc/RapidRAW/commit/dffc46a161f6a9c35037348d9d62b1a5267a99ac), [@17173f2](https://github.com/lalibertemarc/RapidRAW/commit/17173f2873b44f4f7d5f219df1e5e744b3e0dfa9) |

## RapidRoom changes

Expand Down
Loading
Loading