Skip to content

Workaround for solver returning NaN #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmetfrancis merged 2 commits into from
Sep 4, 2025
Merged

Workaround for solver returning NaN #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e5ffc
Detect when d.assemble_mixed returns nan and recompute
emmetfrancis Apr 10, 2024
8709ac5
Merge branch 'development' into emmetfrancis/fix-nan
emmetfrancis Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion smart/solvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
from .common import Stopwatch
from .model_assembly import Compartment

import numpy as np

logger = logging.getLogger(__name__)

__all__ = ["smartSNESProblem"]
Expand Down Expand Up @@ -356,7 +358,14 @@ def assemble_Fnest(self, Fnest):
extra=dict(format_type="log"),
)
continue
Fvecs[j].append(d.as_backend_type(d.assemble_mixed(form)))
# Fvecs[j].append(d.as_backend_type(d.assemble_mixed(form)))
# assemble_mixed sometimes returns nan (nondeterministic???)
cur_vec = d.assemble_mixed(self.Fforms[j][k])
count = 1
while any(np.isnan(cur_vec.get_local())) and count < 10:
cur_vec = d.assemble_mixed(self.Fforms[j][k])
count += 1
Fvecs[j].append(d.as_backend_type(cur_vec))
Fj_petsc[j].zeroEntries()
for k, vec in enumerate(Fvecs[j]):
Fj_petsc[j].axpy(1, vec.vec())
Expand Down