Make Major Updates to Spikewall - #8
Open
JKouga wants to merge 239 commits into
Open
Conversation
Configure URL to listen on all interfaces (Ramen2X#6)
merging branch to update on character and buddy enums
JKouga
changed the title
Ramen2X
reviewed
Apr 14, 2026
| /// Enum that contains the names | ||
| /// and IDs of all Runners League Ranks. | ||
| /// </summary> | ||
| public enum LeagueID |
Owner
There was a problem hiding this comment.
Do you know the actual meanings behind the rank states in this enum? Currently, it's a little ambiguous what rank states these are referring to. Assuming this came from the client, we don't necessarily have to be faithful to the game's enums if we see the opportunity to improve the readability of the code. After all, it doesn't affect their actual value.
Contributor
Author
There was a problem hiding this comment.
I have made the changes
…for all working platforms
… and quick league prizes
…uePrizes sql into Db.cs
… Player Class to a LeaderboardEntry class
…well as call the method for the PlayerEntry property in the WeeklyLeaderboardEntriesResponse() class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the enums needed to operate on the project.