feat: make T: /*snip */ impl Component a feature flag - #454
Draft
sanbox-irl wants to merge 1 commit into
Draft
Conversation
sanbox-irl
force-pushed
the
feat/blanket-component
branch
from
August 17, 2026 01:09
c852acf to
4563e3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a discussion than a full PR -- I think more documentation would be needed to actually merge this.
This PR is about making hecs require a trait to allow a component to be in the ECS.
I explored three different methods of making hecs require a trait to allow a component to be added to the ECS:
hecs::Worldwith a required feature. It was very boilerplate-y, but entirely external to hecs. That isn't such a bad thing! That may still be the best approach since it rocks the boat the least.This seemed promising at first, but the ergnomics that
P = DefaultPolicyseem to offer really fall apart, and simple code which currently compiles fails to compile (notablylet world = World::new()). I think this is the wrong approach right now.I think it's reasonable to point that this is a non-goal of hecs, but at the same time, every mature game that I know of which uses hecs does seem to wrap hecs such that components must satisfy some trait to be added to the ECS.