[WIP] Enhance interop of generics, roles, and classes, Raku or nqp#808
Draft
Kaiepi wants to merge 4 commits into
Draft
[WIP] Enhance interop of generics, roles, and classes, Raku or nqp#808Kaiepi wants to merge 4 commits into
Kaiepi wants to merge 4 commits into
Conversation
- In general, a generic on the RHS can accept anything on the LHS... - ...but a non-generic type on the RHS cannot accept a generic on the LHS... - ...buf if either carry a type signature, we should take advantage of it... - ...mapping type capture to type capture until we find any non-generic type (or Mu). - A return type must not exist on the LHS if one does not exist on the RHS, otherwise it should defer to ACCEPTS as with parameters.
Unlike before: - Spare any unnecessary &EVAL nonsense. - Ensure that generic doees, parents, and a complicated blend of the two can typecheck. - Ensure we can access the doees list before composition (as typechecks may depend on it).
Because the cons of picking Array for type objects (need to decont for `=:=`. not a normal array otherwise) outweigh the pros of mutability here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rakudo/rakudo#4936. @lizmat may be interested in some TODOs now passing.