Skip to content

Simplify Discord subscription require filter labels - #4

Merged
owens1127 merged 1 commit into
mainfrom
fix/subscription-require-filter-labels
Apr 24, 2026
Merged

Simplify Discord subscription require filter labels#4
owens1127 merged 1 commit into
mainfrom
fix/subscription-require-filter-labels

Conversation

@owens1127

Copy link
Copy Markdown
Contributor

Summary

  • simplify Discord subscription rule rendering to only show enabled requirement filters
  • omit false requirement filters to reduce noisy status output
  • update unit test expectations for the new compact filter display

Test plan

  • Verify changed files for lint issues
  • Run PYTHONPATH=. python3 -m pytest tests/test_subscription_helpers.py locally (blocked here by missing jwt dependency)

Made with Cursor

Only render enabled requirement flags in status output, so false filters are omitted and the rule text is easier to scan.

Made-with: Cursor
Copilot AI review requested due to automatic review settings April 24, 2026 05:26
@owens1127
owens1127 merged commit d671ad0 into main Apr 24, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies how Discord subscription rules are rendered in status embeds by only showing enabled requirement filters (and omitting False/disabled requirement flags), reducing noise in the displayed rule strings.

Changes:

  • Update rule string formatting to include only enabled requireFresh / requireCompleted flags, while always showing the raid filter.
  • Adjust unit test expectations to match the new compact filter label output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/commands/subscription_helpers.py Changes _standardized_rule_string() to omit disabled requirement filters and render enabled requirements as require:* labels.
tests/test_subscription_helpers.py Updates assertions to expect require:fresh and to no longer expect output for disabled requireCompleted.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants