Discord: /subscriptions, status embed UX - #3
Merged
Merged
Conversation
- Rename slash command subscription -> subscriptions (manifest + router + copy). - Drop aggregate Rule Filters field; keep per-rule filter lines only. - Subscription status embed: green when destination active, red when inactive. - Align manifest tests with search/subscribe manifest; extend subscription helper tests. Made-with: Cursor
Use neutral greyple for unregistered channels; keep green/red for active/inactive destinations. Fix unregistered status test copy and assert embed color. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Updates the Discord subscription status UX and aligns command naming to the new /subscriptions slash command, including manifest/test updates and improved embed presentation.
Changes:
- Renames the
subscriptionslash command tosubscriptionsacross manifest, routing, user-facing copy, and metrics labels. - Simplifies the status embed by removing the aggregate “Rule Filters” field and adding state-based embed colors (gray/red/green).
- Updates tests to match the current command set and verify new embed colors/copy.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_subscription_helpers.py | Updates helper tests for new status copy, embed colors, and removal of aggregate Rule Filters field. |
| tests/test_manifest_commands.py | Updates manifest expectations for stable slash command names/options, including subscriptions. |
| src/manifest/builders.py | Renames manifest command subscription → subscriptions. |
| src/commands/subscription.py | Updates user-facing guidance and deferred metrics labels to use subscriptions. |
| src/commands/subscription_messages.py | Updates hint copy to direct users to /subscriptions. |
| src/commands/subscription_helpers.py | Removes aggregate Rule Filters summary and implements status-based embed coloring. |
| src/app_factory.py | Updates interaction routing key to subscriptions for the subscription handler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
43
to
48
| command_handlers: dict[str, CommandHandler] = { | ||
| "instance": run_instance_deferred, | ||
| "player-search": run_player_search_deferred, | ||
| "subscribe": run_subscribe_deferred, | ||
| "subscription": run_subscription_deferred, | ||
| "subscriptions": run_subscription_deferred, | ||
| "unsubscribe": run_unsubscribe_deferred, |
| command_handlers: dict[str, CommandHandler] = { | ||
| "instance": run_instance_deferred, | ||
| "player-search": run_player_search_deferred, | ||
| "subscribe": run_subscribe_deferred, |
Align subscribe/unsubscribe with API targets.players / targets.clans (requireFresh, requireCompleted, raids per entry). Remove propagateFilters. Also drop unused /search slash options (membership type, global name) so manifest matches handler and API. Made-with: Cursor
Discord sends the manifest command name (e.g. search). Map search and player-search to the same handler. Keep subscription as an alias for subscriptions during rollout. Made-with: Cursor
Drop instance handler and module (command removed from manifest). Route only search, subscribe, subscriptions, unsubscribe — no legacy player-search or subscription aliases. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscription→subscriptions(manifest, router, user-facing copy, metrics labels).0x747F8D) when not registered, red when registered but destination inactive, green when active.Notes
/subscriptions.Made with Cursor