Fix TypeError: href?.startsWith is not a function in profile raid dots - #388
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
Fix TypeError: href?.startsWith is not a function in profile raid dots#388seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses WEBSITE-34, a
TypeError: href?.startsWith is not a functionthat occurred when clicking raid dots on a user's profile page (/profile/:destinyMembershipId).Root Cause:
When a Next.js
<Link>component was used inside an SVG element insrc/components/__deprecated__/profile/raids/Dot.tsx, it rendered an SVG<a>element. Unlike HTML<a>elements wherehrefis a string, an SVG<a>element'shrefproperty is anSVGAnimatedStringobject. The Next.js router's link interception logic, specificallyhref?.startsWith(), expected a string and thus threw a TypeError when encounteringSVGAnimatedString.Solution:
<Link>with a native SVG<a>element: This ensures thehrefattribute behaves as expected for an SVG anchor.useRouter().push(): AnonClickhandler was added to the<a>element. It callse.preventDefault()to stop the default browser navigation and then usesrouter.push()to perform a client-side route change.e.preventDefault()call is now conditional, allowingCtrl/Cmd + clickor middle-click to open the link in a new tab, mimicking standard browser behavior for links.reftype: TheuseReftype was updated fromHTMLAnchorElementtoSVGAElementto correctly reflect the DOM element type.Fixes WEBSITE-34