Fix TypeError: Response.clone: Body has already been consumed - #385
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
Fix TypeError: Response.clone: Body has already been consumed#385seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses WEBSITE-41, a
TypeError: Response.clone: Body has already been consumed.error occurring insrc/services/bungie/BungieClient.ts.Root Cause:
In
BaseBungieClient.request(), the response body is consumed byawait res.text(). When an error occurs (non-OK response with a Content-Type that is neitherapplication/jsonnortext/html), the code attempts to create aBungieUnkownHTTPErrorby callingnew BungieUnkownHTTPError(res.clone()). However,res.clone()fails because the response body stream has already been consumed by the precedingres.text()call, leading to theTypeError. This effectively masks the true Bungie API error.Solution:
Upon investigation, the
BungieUnkownHTTPErrorconstructor only utilizesresponse.status,response.statusText, andresponse.urlfrom theResponseobject, and does not require access to the response body. Therefore, cloning the response is unnecessary and problematic after the body has been consumed. The fix involves changingres.clone()toreswhen instantiatingBungieUnkownHTTPError, allowing the originalResponseobject (which still contains the necessary metadata) to be passed directly.Fixes WEBSITE-41