Fix WEBSITE-3F: Guard against invalid speedrun categories - #382
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
Fix WEBSITE-3F: Guard against invalid speedrun categories#382seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses WEBSITE-3F, an error occurring when an invalid static category is provided in the URL for speedrun leaderboards (e.g.,
/leaderboards/team/vaultofglass/speedrun/duo).The root cause was that
src/app/leaderboards/team/[raid]/speedrun/[category]/page.tsxhaddynamicParams = truebut lacked validation for thecategoryparameter against theSpeedrunVariablesmapping. This allowed invalid categories to be passed down, eventually causing an error insrc/services/speedrun-com/getSpeedrunComLeaderboard.tswhen attempting to look up a non-existent variable value.The solution adds a
notFound()guard inpage.tsxto check ifparams.categoryis a valid key withinSpeedrunVariables[raid.path].variable.values. If it's not valid, the page now correctly returns a 404, preventing the downstream error.Fixes WEBSITE-3F