Fix profile activity dots not clickable - #381
Merged
Merged
Conversation
Add a transparent SVG hit rect on each dot link so pointer-events:none on decorative children no longer blocks navigation to PGCR. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+232
to
+234
| .dot > .dot-hit { | ||
| pointer-events: all; | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Transparent fill on the SVG rect is sufficient for click targeting. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointer-events: noneon all SVG children (PR Fix all 14 open Sentry issues #379)..dot-hitrect on each dot link as the click target; decorative circle/polygon/skull elements stay non-interactive.Test plan
bun run linthttps://localhost:3000/profile/4611686018519968784— clicked multiple dots, navigated to PGCR (/pgcr/16970348350,/pgcr/16635676227,/pgcr/16629595966)Made with Cursor