Fix WEBSITE-4 hydration crash on invalid route params - #380
Merged
Conversation
Align generateMetadata with page-level notFound() for clan, profile, and PGCR routes so RSC exit status stays consistent. Fixes WEBSITE-4. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unknown root exit status/ React Add admin-only blacklist action to PGCR menu #329):generateMetadatareturned{}or partial robots metadata while the page callednotFound()for invalid clan/profile/PGCR params — RSC exit status mismatch caused client hydration to crash (e.g./clan/www.endgameleagues.com).generateMetadatawith page-levelnotFound()on clan, profile, and PGCR routes.notFound()inside cachedgetClan()— page/metadata own the 404 boundary.not-found.tsxto a server component (no clientPageWrapperboundary).Test plan
bun run lint+tschttps://raidhub.io/clan/www.endgameleagues.com— 404, no console hydration errorFixes WEBSITE-4)Made with Cursor