Skip to content

Fix Atlas Prometheus queries and pantheon PGCR hash resolution - #66

Merged
owens1127 merged 2 commits into
mainfrom
fix/sentry-services-errors
Jun 23, 2026
Merged

Fix Atlas Prometheus queries and pantheon PGCR hash resolution#66
owens1127 merged 2 commits into
mainfrom
fix/sentry-services-errors

Conversation

@owens1127

Copy link
Copy Markdown
Contributor

Summary

  • Clamp Atlas metrics interval to at least 1 minute before building PromQL rate windows, preventing invalid [0m] queries that returned HTTP 400 from Prometheus (Fixes SERVICES-8, SERVICES-9).
  • Resolve pantheon featured-reprise PGCRs using activityDetails.referenceId when Bungie reports a playlist wrapper in directorActivityHash (Fixes SERVICES-2C).

Root cause (SERVICES-2C)

Pantheon featured-reprise playlists (e.g. hash 153253948) report the playlist wrapper as directorActivityHash but the actual encounter (e.g. Argos 796488315) in referenceId. We were storing the wrapper hash, which is not in activity_version.

Sentry issues addressed

Issue Events Fix
SERVICES-8 / SERVICES-9 ~450 GetMetrics() clamps intervalMinutes <= 0 to 1
SERVICES-2C ~1000 resolveInstanceActivityHash() prefers referenceId

Deploy

  • Merge PR
  • ssh raidhubgit pullmake hermessudo systemctl restart hermes
  • Restart Atlas if running as separate service
  • No Postgres migration needed

Test plan

  • go build ./apps/atlas/... ./lib/services/pgcr_processing/...
  • CI green
  • After deploy: SERVICES-2C / SERVICES-8 should stop regressing; reprocess a missed pantheon PGCR if needed

Made with Cursor

Clamp zero-minute rate windows before building PromQL, and store referenceId when Bungie reports a featured-reprise playlist wrapper in directorActivityHash.

Co-authored-by: Cursor <cursoragent@cursor.com>
Comment thread lib/services/pgcr_processing/process-pgcr.go
Normal raid PGCRs report the same hash in both fields; pantheon featured-reprise playlists are the case where they diverge.

Co-authored-by: Cursor <cursoragent@cursor.com>
@owens1127
owens1127 merged commit e6ab13a into main Jun 23, 2026
2 checks passed
@owens1127
owens1127 deleted the fix/sentry-services-errors branch June 23, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant