Fix Atlas Prometheus queries and pantheon PGCR hash resolution - #66
Merged
Conversation
Clamp zero-minute rate windows before building PromQL, and store referenceId when Bungie reports a featured-reprise playlist wrapper in directorActivityHash. Co-authored-by: Cursor <cursoragent@cursor.com>
Normal raid PGCRs report the same hash in both fields; pantheon featured-reprise playlists are the case where they diverge. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[0m]queries that returned HTTP 400 from Prometheus (Fixes SERVICES-8, SERVICES-9).activityDetails.referenceIdwhen Bungie reports a playlist wrapper indirectorActivityHash(Fixes SERVICES-2C).Root cause (SERVICES-2C)
Pantheon featured-reprise playlists (e.g. hash
153253948) report the playlist wrapper asdirectorActivityHashbut the actual encounter (e.g. Argos796488315) inreferenceId. We were storing the wrapper hash, which is not inactivity_version.Sentry issues addressed
GetMetrics()clampsintervalMinutes <= 0to 1resolveInstanceActivityHash()prefersreferenceIdDeploy
ssh raidhub→git pull→make hermes→sudo systemctl restart hermesTest plan
go build ./apps/atlas/... ./lib/services/pgcr_processing/...Made with Cursor