Fix fix-sherpa-clears for current schema and missing repair views - #61
Merged
Conversation
The repair script was broken on prod because cache matviews no longer exist and SQL still referenced pre-migration table names. It now creates the views at runtime, uses schema-qualified tables, and avoids zeroing player_stats rows missing from cache. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix-sherpa-clearsafter schema migration: usecore.*,definitions.*, andcache.*qualified namescache.firsts_clears_tmp,cache.noob_counts, andcache.p_stats_cacheat runtime if missing (no migration required)p_stats_cacheaggregation so activities without a fresh clear are not dropped and total time includes DNF rowsplayer_statsvia inner join to cache (avoid zeroing rows) and add-stats-onlyflagTest plan
:5433with prod sample (3k recent instances)./bin/fix-sherpa-clearscompleted in ~500msMade with Cursor