Fix community race leaderboard membership_ids for DNF players - #60
Merged
Conversation
Only include completed instance_player rows in team_pantheon_custom_race_leaderboard and sort by kills. Co-authored-by: Cursor <cursoragent@cursor.com>
| FROM ranked | ||
| LEFT JOIN LATERAL ( | ||
| SELECT JSONB_AGG(ip.membership_id ORDER BY ip.completed DESC, ip.time_played_seconds DESC) AS membership_ids | ||
| SELECT JSONB_AGG(ip.membership_id ORDER BY ip.kills DESC) AS membership_ids |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Drop kills ordering to match contest and first materialized views. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
team_pantheon_custom_race_leaderboardto only include completedinstance_playerrows inmembership_ids, matching contest/first team leaderboardsCompanion PR: Raid-Hub/API#144 (API lateral player query)
Test plan
/leaderboard/team/custom/pantheon-community-raceand confirm cleared runs no longer show DNF playersPost-merge (prod)
Migrations are not applied in prod. After merging and deploying the API, run this against Postgres to recreate the materialized view: