Instance Standing Bug Fixes - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
InstanceStandingschema, test cases, and the SQL queries in thegetInstancePlayersStandingfunction to enhance functionality and improve data accuracy. The most significant changes include making theindividualReasonfield nullable, adding a new test case, and optimizing SQL queries for better performance and data filtering.Schema Updates:
zInstancePlayerStandingschema to allow theindividualReasonfield to be nullable, ensuring compatibility with records where this field might not be present. (src/schema/components/InstanceStanding.ts, src/schema/components/InstanceStanding.ts)Test Enhancements:
getInstancePlayersStandingfunction's output, including checks for array length, specific membership IDs, and parsed schema validation. (src/services/reporting/standing.test.ts, src/services/reporting/standing.test.ts)SQL Query Optimizations:
getInstancePlayersStandingfunction:JOIN ... ONwithUSINGfor cleaner SQL syntax in certain joins. (src/services/reporting/standing.ts, src/services/reporting/standing.ts)src/services/reporting/standing.ts, src/services/reporting/standing.ts)src/services/reporting/standing.ts, src/services/reporting/standing.ts)