Fix Sentry API input validation and blacklist enum cast - #148
Merged
Conversation
…rors. Reject out-of-range membership IDs and duration filters at the route layer, and schema-qualify BlacklistReportSource on admin blacklist inserts. Co-authored-by: Cursor <cursoragent@cursor.com>
Barecheck - Code coverage reportTotal: 91.51%Your code coverage diff: 0.01% ▴ Uncovered files and lines
|
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BIGINTmax and duration filters aboveINTEGERmax at route validation, returning 400 instead of unhandled DB errors (Fixes API-12, API-1A, API-1K, API-1Q).flagging."BlacklistReportSource"on admin blacklist inserts so prod Postgres finds the enum type (Fixes API-1M).Sentry issues addressed
value "10000000000" is out of range for type integerzPgInt32()onminDurationSeconds/maxDurationSecondsvalue "46116860184306851060" is out of range for type bigintzBigIntString()capped atPG_BIGINT_MAXtype "BlacklistReportSource" does not exist::flagging."BlacklistReportSource"cast in INSERTTest plan
bun test src/schema/input.test.tsbun run typecheckMade with Cursor