feat(pantheon): Pantheon 2.0 modes and manifest-driven version lookup - #132
Merged
Conversation
Add pantheon manifest helpers, gauntletVersionIds, path-based leaderboard lookup, and sunset-aware activity examples without hardcoding activity 101. Co-authored-by: Cursor <cursoragent@cursor.com>
…sts. Gauntlet manifest infrastructure remains; only the hardcoded id 134 definition was removed. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the API’s Pantheon support to handle “Pantheon 2.0” by deriving Pantheon activity/version IDs from manifest data (and DB lookups) instead of hardcoding legacy activity 101, and extends manifest/OpenAPI artifacts to reflect the newer Pantheon IDs and modes.
Changes:
- Added
src/services/manifest/pantheon.tshelpers to derive Pantheon activity IDs, Gauntlet version IDs, and to resolve Pantheon version IDs by(activity.path, version.path)via SQL. - Updated
/manifestresponse to returnpantheonIds(sorted active-first) and a newgauntletVersionIdsfield. - Updated individual Pantheon leaderboard routing to resolve version IDs via
getPantheonVersionIdand added a test for the newcaluspath; updated schema/OpenAPI examples for the new Pantheon IDs/versions.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/services/manifest/pantheon.ts | New Pantheon-specific manifest helpers, including DB-backed version resolution. |
| src/services/manifest/pantheon.test.ts | Unit tests for Pantheon helper logic (activity ID filtering/sorting and gauntlet version ID extraction). |
| src/services/manifest/definitions.ts | Adds a generic getActivityIdByPath DB helper. |
| src/schema/components/VersionDefinition.ts | Extends OpenAPI examples with new Pantheon 2.0 version IDs/paths. |
| src/schema/components/ActivityDefinition.ts | Updates OpenAPI examples to include Pantheon 101/102 activity definitions. |
| src/routes/manifest.ts | Emits pantheonIds and new gauntletVersionIds derived from manifest definitions. |
| src/routes/leaderboard/individual/pantheon.ts | Resolves Pantheon version IDs via manifest-driven lookup instead of hardcoded activity 101. |
| src/routes/leaderboard/individual/pantheon.test.ts | Adds a 200-path test for version=calus. |
| open-api/openapi.json | Regenerated OpenAPI output reflecting the schema/manifest response changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
+26
| .openapi({ | ||
| description: "The definition of an activity in the RaidHub database.", | ||
| example: { | ||
| id: 9, | ||
| name: "Vault of Glass", | ||
| path: "vaultofglass", | ||
| isSunset: false, | ||
| isRaid: true, | ||
| releaseDate: new Date("2021-05-22T00:00:00Z"), | ||
| dayOneEnd: new Date("2021-05-23T00:00:00Z"), | ||
| contestEnd: new Date("2021-05-23T00:00:00Z"), | ||
| weekOneEnd: new Date("2021-05-25T00:00:00Z"), | ||
| milestoneHash: 1888320892, | ||
| splashSlug: "vog" | ||
| } | ||
| examples: [ | ||
| { |
5 tasks
Query both pantheon activity paths for manifest discovery and leaderboard version lookup. Remove calus integration test until Services data is seeded. Co-authored-by: Cursor <cursoragent@cursor.com>
…field. Recognize both pantheon and thepantheon activity paths for manifest IDs and version lookup; gauntletVersionIds remains manifest-driven with no placeholder version 134. Co-authored-by: Cursor <cursoragent@cursor.com>
Gauntlet mode details are unknown, so drop gauntletVersionIds and related helpers until Bungie data exists. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
Reinstate getGauntletVersionIds in manifest response after accidental removal. Drop calus integration test until Services data is seeded. Regenerate OpenAPI. Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pantheon 2.0 API support for dual activities and manifest-driven version lookup.
The Pantheon, paththepantheon, sunset): EP boss versions 128–131Pantheon, pathpantheon, permanent 9.7.0 return): versions 132 Calus, 133 MorgethgetPantheonActivityIdsandgetPantheonVersionIdmatch bothpantheonandthepantheonactivity paths (active activity preferred when paths collide)pantheonIds,gauntletVersionIds(infrastructure for gauntlet modes when present in DB — no hardcoded v134)Deploy order
docs/pantheon-2.0-deploy-plan.md(activity 101 sunset +thepantheonpath, activity 102, versions 132–133, hash mappings)leaderboard.individual_pantheon_version_leaderboardTest plan
bun test src/services/manifest/pantheon.test.tsbun test src/routes/leaderboard/individual/pantheon.test.ts(legacy versions; Calus/Morgeth need seeded DB)bun run typecheckandbun format --check/manifestreturnsisSunsetfor 101, active 102, andgauntletVersionIdswhen gauntlet versions existatraks,oryx, etc.) and new paths (calus,morgeth) after data deployPantheonVersionNotFound