capture internal api error - #119
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds structured logging for internal service failures in the /status endpoint so InternalApiError incidents are captured (including via Sentry integration in Logger.error) while still returning a 503 to clients.
Changes:
- Introduce a
Loggerinstance forSTATUS_ROUTE. - When catching
InternalApiError, log the error with relevant context fields (service name, URL, status).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }) | ||
| } catch (err) { | ||
| if (err instanceof InternalApiError) { | ||
| // log the error as a error for sentry |
There was a problem hiding this comment.
The inline comment has a grammar/spelling issue and is a bit unclear. Consider updating it to “log the error as an error for Sentry” (or rephrasing to note that Logger.error captures to Sentry).
Suggested change
| // log the error as a error for sentry | |
| // Log the error as an error in Sentry (via Logger.error) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.