Skip to content

Add isAdministratorRoute flag to admin reporting routes + regenerate OpenAPI - #117

Merged
owens1127 merged 3 commits into
mainfrom
copilot/add-player-standing-api
Feb 22, 2026
Merged

Add isAdministratorRoute flag to admin reporting routes + regenerate OpenAPI#117
owens1127 merged 3 commits into
mainfrom
copilot/add-player-standing-api

Conversation

Copilot AI commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

All four admin reporting routes were missing isAdministratorRoute: true, so the generated OpenAPI spec omitted 403 responses and "Administrator Token" security schemes for those routes. This caused the verify-open-api-doc CI check to fail (committed spec ≠ freshly generated spec).

Changes

  • player-standing.ts, instance-standing.ts, blacklist.ts, player.ts — added isAdministratorRoute: true to each RaidHubRoute constructor
  • instance-standing.ts — replaced stale copy-pasted description with an accurate one
  • open-api/openapi.json — regenerated; all four reporting routes now carry 403 + Administrator Token security
 export const getPlayerStanding = new RaidHubRoute({
+    isAdministratorRoute: true,
     method: "get",
     ...
 })
Original prompt

This section details on the original issue you should resolve

<issue_title>Player Standing API</issue_title>
<issue_description>Blocks Raid-Hub/Web-App#294</issue_description>

<agent_instructions>We need an API to get the standing of a player's account. Look at the frontend ticket to understand the data here. should be a /admin route</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: owens1127 <98496129+owens1127@users.noreply.github.com>
…API docs

Co-authored-by: owens1127 <98496129+owens1127@users.noreply.github.com>
Copilot AI changed the title [WIP] Add API to retrieve player standing information Add isAdministratorRoute flag to admin reporting routes + regenerate OpenAPI Feb 22, 2026
@owens1127
owens1127 marked this pull request as ready for review February 22, 2026 03:30
Copilot AI review requested due to automatic review settings February 22, 2026 03:30
@barecheck

barecheck Bot commented Feb 22, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 92.87%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
src/routes/admin/reporting/blacklist.ts53-91
src/routes/admin/reporting/player.ts34-52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missing configuration flag on four admin reporting routes that caused the OpenAPI specification to be incomplete. The routes were missing isAdministratorRoute: true, which resulted in the generated OpenAPI spec omitting 403 Forbidden responses and Administrator Token security schemes.

Changes:

  • Added isAdministratorRoute: true flag to four admin reporting route constructors
  • Fixed stale copy-pasted description in instance-standing route to accurately describe its purpose
  • Regenerated OpenAPI specification to include proper 403 responses and security schemes for all four routes

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/routes/admin/reporting/player.ts Added isAdministratorRoute: true to patchPlayer route
src/routes/admin/reporting/player-standing.ts Added isAdministratorRoute: true to getPlayerStanding route; cleaned up import formatting
src/routes/admin/reporting/instance-standing.ts Added isAdministratorRoute: true and fixed stale description to accurately describe the instance standing endpoint
src/routes/admin/reporting/blacklist.ts Added isAdministratorRoute: true to blacklistInstanceRoute
open-api/openapi.json Regenerated OpenAPI spec with 403 Forbidden responses and Administrator Token security schemes for all four reporting routes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@owens1127
owens1127 merged commit 3adcc84 into main Feb 22, 2026
10 checks passed
@owens1127
owens1127 deleted the copilot/add-player-standing-api branch February 22, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Player Standing API

3 participants