Skip to content

Project Review#41

Open
nj7 wants to merge 1 commit into
masterfrom
review
Open

Project Review#41
nj7 wants to merge 1 commit into
masterfrom
review

Conversation

@nj7

@nj7 nj7 commented Oct 5, 2022

Copy link
Copy Markdown

Lumen5-Clone-Project

  • Functionality Coould have been implemented
  • Most of the feature are hard code and do not work
  • Final video is static, could have been better to have multiple option as per user inputs
  • The Demo Was Up and running

fw16_346

  • Git commit should have comments not name
  • Should have added description for the pr.
  • Copying code from website directly does not work in real world

fw17_0862

  • Git commit should have comments not name
  • Should have added description for the pr.
  • could have used css file for formatting rather than having style tag

fw17_0116

  • Git commit should have comments not name
  • Should have added description for the pr.
  • Instead of using static video file could have added video for all the template and restrict the tempalte to few only,
  • Should have restricted content element as well should not show using blog and converting to video was working.
  • there should have been a redirect to profile link, can't get out from video page

fw17_0688

  • Git commit should have comments not name
  • Should have added description for the pr.
  • Login functionality does not work, can directly update data file on new entry
  • User level segregation of video should have been done ie logged in user should only be able to see his/her videos
  • Should have removed feature that is not useable rather than to show them in the application
  • Logout functionality does not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant