Wire completeness intro to cross-platform gstack-open-url - #3
Draft
RachaelQuisel wants to merge 2 commits into
Draft
Wire completeness intro to cross-platform gstack-open-url#3RachaelQuisel wants to merge 2 commits into
RachaelQuisel wants to merge 2 commits into
Conversation
The first-time Boil the Lake intro hardcoded macOS `open`, which silently fails on Linux and Windows. Point generateLakeIntro() at the existing bin/gstack-open-url helper (open / xdg-open / start + headless fallback) so the essay launch works everywhere. Mark the TODO shipped. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QCGf8qGNaSX8JaMYbVDL88
Ran bun run gen:skill-docs after wiring generateLakeIntro() to the cross-platform URL helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QCGf8qGNaSX8JaMYbVDL88
Reviewer's GuideWires the Boil the Lake intro flow to the existing cross-platform gstack-open-url helper and regenerates SKILL docs to match, while marking the corresponding TODO as shipped. Sequence diagram for cross-platform lake intro URL openingsequenceDiagram
actor User
participant gstack_cli
participant gstack_open_url_helper
participant Browser
User->>gstack_cli: run_gstack_first_time
gstack_cli->>User: generateLakeIntro_prompt
User->>gstack_cli: confirm_open_essay
gstack_cli->>gstack_open_url_helper: gstack-open-url boil_the_ocean_url
alt macOS
gstack_open_url_helper->>Browser: open boil_the_ocean_url
else Linux
gstack_open_url_helper->>Browser: xdg-open boil_the_ocean_url
else Windows
gstack_open_url_helper->>Browser: start boil_the_ocean_url
else headless
gstack_open_url_helper->>User: print_url_to_stdout
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The first-time Boil the Lake intro (
generateLakeIntro()inscripts/resolvers/preamble.ts) hardcoded macOSopento launch the essay. On Linux and Windows that command doesn't exist, so the launch silently failed. This wires the intro to the existing cross-platformbin/gstack-open-urlhelper (openon macOS,xdg-openon Linux,starton Windows, with a plain URL-print fallback for headless environments).Implements the Cross-platform URL open helper TODO from
TODOS.md(the helper script already existed; this completes the story by actually using it in the one place the TODO called out).Changes
scripts/resolvers/preamble.ts—generateLakeIntro(ctx)now emits${binDir}/gstack-open-url <url>instead ofopen <url>, matching thebinDirpattern used elsewhere in the resolver.SKILL.mdfiles viabun run gen:skill-docs(separate commit).TODOS.md— marked the item SHIPPED.Testing
bun test test/skill-validation.test.ts test/gen-skill-docs.test.ts— 614 pass, 0 fail.bun testrun are pre-existing environment issues (browse integration tests need the compiled binary +npx playwright install, neither present in a fresh clone) and are unrelated to this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01QCGf8qGNaSX8JaMYbVDL88
Generated by Claude Code
Summary by Sourcery
Wire the first-time Completeness Principle intro to the existing cross-platform URL opener and update docs to reflect the change.
Bug Fixes:
open, preventing silent failures on Linux and Windows.Documentation:
gstack-open-urlhelper instead of the macOS-onlyopencommand.