Skip to content

fix: add Write to headed-mode server allowedTools #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RachaelQuisel wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −1
Draft

fix: add Write to headed-mode server allowedTools #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ade88cc
fix: add Write to headed-mode server allowedTools
claude Apr 9, 2026
86cf7c0
fix: add Write to server allowedTools for headed-mode sidebar
claude Aug 21, 2026
8ab95c8
fix: remove duplicate Write allowedTools test
claude Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browse/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ function spawnClaude(userMessage: string, extensionUrl?: string | null, forTabId
// Never resume — each message is a fresh context. Resuming carries stale
// page URLs and old navigation state that makes the agent fight the user.
const args = ['-p', prompt, '--model', 'opus', '--output-format', 'stream-json', '--verbose',
'--allowedTools', 'Bash,Read,Glob,Grep'];
'--allowedTools', 'Bash,Read,Glob,Grep,Write'];

addChatEntry({ ts: new Date().toISOString(), role: 'agent', type: 'agent_start' });

Expand Down
10 changes: 10 additions & 0 deletions browse/test/sidebar-security.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,16 @@ describe('Sidebar prompt injection defense', () => {
expect(SERVER_SRC).toContain('refuse');
});

// --- Allowed Tools (server + agent must stay in sync) ---

test('server allowedTools includes Write', () => {
// Write does not expand attack surface beyond Bash (which can already
// write files). The server args are the source of truth — if Write is
// missing here, the sidebar agent cannot use it even if the agent
// fallback includes it, because the server-provided args take precedence.
expect(SERVER_SRC).toContain("'--allowedTools', 'Bash,Read,Glob,Grep,Write'");
});

// --- Sidebar Agent Arg Plumbing ---

test('sidebar-agent uses queued args from server, not hardcoded', () => {
Expand Down