Skip to content

test: stabilize Insights sample bundle loading - #9

Merged
Raafet57 merged 1 commit into
mainfrom
fix/insights-sample-test-flake
May 5, 2026
Merged

test: stabilize Insights sample bundle loading#9
Raafet57 merged 1 commit into
mainfrom
fix/insights-sample-test-flake

Conversation

@Raafet57

@Raafet57 Raafet57 commented May 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes the post-merge main CI failure from run 25372579744.
  • Stabilizes InsightsPage.test.tsx sample-bundle interactions by waiting for the manifest-loaded select to be enabled and for the requested option to exist before user.selectOptions.
  • Test-only change; no product/runtime behavior changed.

Failure addressed

pnpm test failed on main after PR #8 merge because the sample-bundle test tried to select linked while the async manifest was still in the Loading bundles… placeholder state.

Verification

  • pnpm test -- src/pages/InsightsPage.test.tsx repeated 3x — passed, 27 files / 200 tests each run.
  • pnpm test — passed, 27 files / 200 tests.
  • pnpm format
  • pnpm verify — passed: lint, format check, typecheck, unit tests, privacy audit, deterministic data checks, build.
  • pnpm test:e2e — passed, 18/18.
  • npx -y @google/design.md lint DESIGN.md — 0 errors; existing unused-token warnings only.
  • git diff --check — passed.
  • Codex implementation review: APPROVED.

Boundaries

  • No runtime/product code changed.
  • No backend, upload path, telemetry, persistence, deployment, release, tag, or publication.

@Raafet57
Raafet57 merged commit 2d7e125 into main May 5, 2026
1 check passed
@Raafet57
Raafet57 deleted the fix/insights-sample-test-flake branch May 5, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant