feat: expand IBAN workbench - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ibaninto an IBAN Workbench with Validate, Build, Catalogue, and Provenance panels.Motivation
The roadmap’s next product refinement was to turn the narrow IBAN validator into a fuller offline workbench while preserving the suite’s browser-only/privacy-first and no-live-reference-data boundaries.
Changes
src/lib/iban/structure.tsandsrc/lib/iban/build.tsfor BBAN template derivation and IBAN assembly./ibaninto tabbed Validate / Build / Catalogue / Provenance panels.scripts/privacy-audit.shwith IBAN-specific banned API checks.Test Plan
git diff --checkpnpm verifypnpm test:e2e— 20/20 passednpx -y @google/design.md lint DESIGN.md— 0 errors, existing unused-token warnings onlyfetch, XHR, storage, cookie, or telemetry API usageAPPROVEDNotes for Reviewers
computeCheckDigitsnecessarily left-pads the computed two-digit check value, but BBAN/user fields are never auto-padded.