Add function args serialization to RCCL buffer records #129
Closed
rocm-devops wants to merge 8 commits into
Closed
Add function args serialization to RCCL buffer records #129rocm-devops wants to merge 8 commits into
rocm-devops wants to merge 8 commits into
Conversation
Author
Author
|
RCCL test is failing because of this Probably because of this (new?) ISA |
rocm-devops
requested review from
MythreyaK,
ammarwa,
bgopesh,
bwelton,
jrmadsen and
t-tye
as code owners
August 7, 2025 22:35
Author
|
Created #536 for some failing tests. |
12 tasks
|
Imported to rocm-systems |
Closed
4 tasks
prasanna-amd
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Jul 8, 2026
Add RCCL_API_EXT buffer tracing kind that captures RCCL function arguments and return values alongside existing trace metadata. This mirrors the existing HIP_API_EXT pattern. Includes test infrastructure with single-process multi-GPU RCCL test and pytest validators for JSON, CSV, and Perfetto output formats. Rebased onto current develop, resolving conflicts with refactored test infrastructure (rocprofiler_add_integration_execute_test / rocprofiler_add_integration_validate_test). Originally from ROCm/rocprofiler-sdk#129 by Mythreya Kuricheti. Ref: SWDEV-528449, SWDEV-527517
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Details
Adds RCCL function parameter serialization. Requested by RCCL team.
No ticket yet, but they asked if nvtx ranges were supported. This request is not in this ticket / pr, but wanted to add this here.
Associated Jira Ticket Number/Link
SWDEV-528449
SWDEV-527517
What type of PR is this? (check all applicable)
Technical details
Adds RCCL function parameter serialization
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?